docs(isIdentityCard): fix listed locales #2340
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2340 +/- ##
===========================================
- Coverage 100.00% 99.95% -0.05%
===========================================
Files 109 107 -2
Lines 2489 2449 -40
Branches 628 619 -9
===========================================
- Hits 2489 2448 -41
- Partials 0 1 +1 ☔ View full report in Codecov by Sentry. |
WikiRik
previously approved these changes
Nov 20, 2023
|
Don't mind the failure of codecov/project. That is not due to your PR |
rubiin
previously approved these changes
May 12, 2024
profnandaa
requested changes
Jun 22, 2024
| @@ -120,7 +120,11 @@ Validator | Description | |||
| **isHexColor(str)** | check if the string is a hexadecimal color. | |||
| **isHSL(str)** | check if the string is an HSL (hue, saturation, lightness, optional alpha) color based on [CSS Colors Level 4 specification][CSS Colors Level 4 Specification].<br/><br/>Comma-separated format supported. Space-separated format supported with the exception of a few edge cases (ex: `hsl(200grad+.1%62%/1)`). | |||
| **isIBAN(str, [, options])** | check if the string is an IBAN (International Bank Account Number).<br/><br/>`options` is an object which accepts two attributes: `whitelist`: where you can restrict IBAN codes you want to receive data from and `blacklist`: where you can remove some of the countries from the current list. For both you can use an array with the following values `['AD','AE','AL','AT','AZ','BA','BE','BG','BH','BR','BY','CH','CR','CY','CZ','DE','DK','DO','EE','EG','ES','FI','FO','FR','GB','GE','GI','GL','GR','GT','HR','HU','IE','IL','IQ','IR','IS','IT','JO','KW','KZ','LB','LC','LI','LT','LU','LV','MC','MD','ME','MK','MR','MT','MU','MZ','NL','NO','PK','PL','PS','PT','QA','RO','RS','SA','SC','SE','SI','SK','SM','SV','TL','TN','TR','UA','VA','VG','XK']`. | |||
| <<<<<<< docs/fix-listed-isIdentityCard-locales -- Incoming Change | |||
There was a problem hiding this comment.
Been meaning to, looks like @rubiin introduced that recently.
Will try to get to it over the weekend.
There was a problem hiding this comment.
must have left that when I fixed the conflict from github UI :|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the
MZlocale from the list of allowed locales forisIdentityCard, since a validation method has never been added for said locale.It was added in #1604, presumably by mistake.
Checklist